This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25298 ) Change subject: MS Power Control Loop: Support set up of C/I parameters for osmo-bts ...................................................................... Patch Set 5: Code-Review-1 (6 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/25298/5/doc/manuals/chapters/power_control.adoc File doc/manuals/chapters/power_control.adoc: https://gerrit.osmocom.org/c/osmo-bsc/+/25298/5/doc/manuals/chapters/power_control.adoc@211 PS5, Line 211: The general idea of power control is to maintain the signal level (RxLev) and Looks like an unrelated/unneeded reformatting change to me. I don't see words added or removed, things just moved around. https://gerrit.osmocom.org/c/osmo-bsc/+/25298/5/doc/manuals/chapters/power_control.adoc@257 PS5, Line 257: rxlev-thresh lower 32 upper 38 <2> These changes also look unrelated to me. I am not against them, just don't see how could they related to the C/I parameters you're adding. I would CR+2 a separate change, thanks! https://gerrit.osmocom.org/c/osmo-bsc/+/25298/5/doc/manuals/chapters/power_control.adoc@368 PS5, Line 368: ci-avg amr-fr algo osmo-ewma beta 50 <4> Looks like you wanted to use <6> and <7> here. https://gerrit.osmocom.org/c/osmo-bsc/+/25298/2/src/osmo-bsc/bts_vty.c File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25298/2/src/osmo-bsc/bts_vty.c@3068 PS2, Line 3068: Channel Type (E)GPRS > So far, I'm just adding it for completeness when doing all the monkey-type work, since we got values […] I would still avoid making this configurable in the VTY unless it's actually implemented. https://gerrit.osmocom.org/c/osmo-bsc/+/25298/5/src/osmo-bsc/bts_vty.c File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25298/5/src/osmo-bsc/bts_vty.c@3227 PS5, Line 3227: lower_cmp_p, lower_cmp_n Not fixed: upper_cmp_p, upper_cmp_n. https://gerrit.osmocom.org/c/osmo-bsc/+/25298/5/src/osmo-bsc/gsm_data.c File src/osmo-bsc/gsm_data.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25298/5/src/osmo-bsc/gsm_data.c@1201 PS5, Line 1201: C/I averaging is not yet implemented As far as I can see, I52eb0558fd7a215a6ee0b2aced189ae4a37d8a22 implements it in osmo-bts. So I guess it makes sense to enable EWMA with some alpha by default? Or at least remove this comment? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7e76ec47b323d469f777624b74b08752d1f5584f Gerrit-Change-Number: 25298 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Fri, 03 Sep 2021 16:16:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210903/59cc3be4/attachment.htm>