Change in osmo-bts[master]: MS Power Control Loop: Take C/I into account

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25268 )

Change subject: MS Power Control Loop: Take C/I into account
......................................................................


Patch Set 5:

(3 comments)

some vty prints are wrong, rest looks good

https://gerrit.osmocom.org/c/osmo-bts/+/25268/5//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-bts/+/25268/5//COMMIT_MSG@9 
PS5, Line 9: MW
MS?


https://gerrit.osmocom.org/c/osmo-bts/+/25268/5/src/common/rsl.c 
File src/common/rsl.c:

https://gerrit.osmocom.org/c/osmo-bts/+/25268/5/src/common/rsl.c@1059 
PS5, Line 1059: 		#define SET_AVE_CFG(PARAMS, FROM, TYPE, PARAM_OFFSET) do {\
(IMHO this would be more readable as function instead of a macro)


https://gerrit.osmocom.org/c/osmo-bts/+/25268/5/src/common/vty.c 
File src/common/vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/25268/5/src/common/vty.c@1423 
PS5, Line 1423: ci_amr_fr_meas
ci_amr_hr_meas, below for SDCCH and GPRS it's also wrong



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25268
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5dfd8ff9ab6b499646498b507624758dcc160fb6
Gerrit-Change-Number: 25268
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 03 Sep 2021 13:52:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210903/4225fcef/attachment.htm>