Change in osmo-trx[master]: computeCI(): Rename verbose repeated getter to constant

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Sep 2 17:53:08 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/25318 )

Change subject: computeCI(): Rename verbose repeated getter to constant
......................................................................

computeCI(): Rename verbose repeated getter to constant

Change-Id: I9b426d01a282f572c0b915c5666642dce4c60475
---
M Transceiver52M/sigProcLib.cpp
1 file changed, 5 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp
index 7169a15..1a72e00 100644
--- a/Transceiver52M/sigProcLib.cpp
+++ b/Transceiver52M/sigProcLib.cpp
@@ -1464,20 +1464,21 @@
 static float computeCI(const signalVector *burst, const CorrelationSequence *sync,
                        float toa, int start, const complex &xcorr)
 {
+  const int N = sync->sequence->size();
   float S, C;
   int ps;
 
   /* Integer position where the sequence starts */
-  ps = start + 1 - sync->sequence->size() + (int)roundf(toa);
+  ps = start + 1 - N + (int)roundf(toa);
 
   /* Estimate Signal power */
   S = 0.0f;
-  for (int i=0, j=ps; i<(int)sync->sequence->size(); i++,j++)
+  for (int i=0, j=ps; i<(int)N; i++,j++)
     S += (*burst)[j].norm2();
-  S /= sync->sequence->size();
+  S /= N;
 
   /* Esimate Carrier power */
-  C = xcorr.norm2() / ((sync->sequence->size() - 1) * sync->gain.abs());
+  C = xcorr.norm2() / ((N - 1) * sync->gain.abs());
 
   /* Interference = Signal - Carrier, so C/I = C / (S - C) */
   return 3.0103f * log2f(C / (S - C));

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/25318
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I9b426d01a282f572c0b915c5666642dce4c60475
Gerrit-Change-Number: 25318
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210902/8564e248/attachment.htm>


More information about the gerrit-log mailing list