Change in osmo-ci[master]: lint: checkpatch_osmo.sh: ignore LONG_LINE_*

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Wed Sep 1 14:11:44 UTC 2021


osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/25301 )


Change subject: lint: checkpatch_osmo.sh: ignore LONG_LINE_*
......................................................................

lint: checkpatch_osmo.sh: ignore LONG_LINE_*

According to a comment in checkpatch.pl, these should automatically be
ignored when LONG_LINE is ignored. However I found that it's still
complaining about LONG_LINE_COMMENT, so explicitly disable it.

Related: OS#5087
Change-Id: I7aed3bfbfcb0b9e2f1d743b111e8418846f031d2
---
M lint/checkpatch/checkpatch_osmo.sh
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/01/25301/1

diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh
index b465b5a..849ccda 100755
--- a/lint/checkpatch/checkpatch_osmo.sh
+++ b/lint/checkpatch/checkpatch_osmo.sh
@@ -24,7 +24,7 @@
 # * INITIALISED_STATIC: we use this, see also http://lkml.iu.edu/hypermail/linux/kernel/0808.1/2235.html
 # * LINE_CONTINUATIONS: false positives
 # * LINE_SPACING: we don't always put a blank line after declarations
-# * LONG_LINE: should be 120 chars, but exceptions are done often so don't fail here
+# * LONG_LINE*: should be 120 chars, but exceptions are done often so don't fail here
 # * PREFER_DEFINED_ATTRIBUTE_MACRO: macros like __packed not defined in libosmocore
 # * PREFER_FALLTHROUGH: pseudo keyword macro "fallthrough" is not defined in libosmocore
 # * REPEATED_WORD: false positives in doxygen descriptions (e.g. '\param[in] data Data passed through...')
@@ -54,6 +54,8 @@
 	--ignore LINE_CONTINUATIONS \
 	--ignore LINE_SPACING \
 	--ignore LONG_LINE \
+	--ignore LONG_LINE_COMMENT \
+	--ignore LONG_LINE_STRING \
 	--ignore PREFER_DEFINED_ATTRIBUTE_MACRO \
 	--ignore PREFER_FALLTHROUGH \
 	--ignore REPEATED_WORD \

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/25301
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I7aed3bfbfcb0b9e2f1d743b111e8418846f031d2
Gerrit-Change-Number: 25301
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210901/8ecbca06/attachment.htm>


More information about the gerrit-log mailing list