This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25976 ) Change subject: heighbor_ident: add/del neighbor cells via ctrl interface ...................................................................... Patch Set 5: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/25976/5/doc/manuals/chapters/control.adoc File doc/manuals/chapters/control.adoc: https://gerrit.osmocom.org/c/osmo-bsc/+/25976/5/doc/manuals/chapters/control.adoc@148 PS5, Line 148: FIXME: add variables defined in src/ctrl/control_if.c? > I would comment this line out: […] that line already existed before hand. So if you want to change that, it is a separate change and shouldn't be considered as part of the review of this patch. https://gerrit.osmocom.org/c/osmo-bsc/+/25976/5/src/osmo-bsc/neighbor_ident_ctrl.c File src/osmo-bsc/neighbor_ident_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25976/5/src/osmo-bsc/neighbor_ident_ctrl.c@48 PS5, Line 48: return 1; it is unusual in osmocom code to return positive integers in error case. In general, we use negative values for errors, zero for success, and positive values if there is anything to count. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I343a40e18fa9b91e6c381912c0426a002841e079 Gerrit-Change-Number: 25976 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Sun, 31 Oct 2021 08:04:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211031/72ee00f3/attachment.htm>