Change in osmo-bts[master]: lchan_meas_handle_sacch(): check if Measurement Result is valid

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Oct 31 07:47:54 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26047 )

Change subject: lchan_meas_handle_sacch(): check if Measurement Result is valid
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/26047/2/src/common/measurement.c 
File src/common/measurement.c:

https://gerrit.osmocom.org/c/osmo-bts/+/26047/2/src/common/measurement.c@954 
PS2, Line 954: 		i
isn't the logic exactly wrong then?  You are using mr->dtx_used if meas_valid == 1.  While at the same time your coment states "0 =[=] valid"



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26047
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4aaac742674ce3ac15e9a4a32fe7c72db81d32d2
Gerrit-Change-Number: 26047
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sun, 31 Oct 2021 07:47:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211031/d263bbb8/attachment.htm>


More information about the gerrit-log mailing list