Change in osmo-bsc[master]: bsc_subscr_conn_fsm: fix mgw-pool ref counting

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Thu Oct 28 17:23:00 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26011 )

Change subject: bsc_subscr_conn_fsm: fix mgw-pool ref counting
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/26011/1/src/osmo-bsc/bsc_subscr_conn_fsm.c 
File src/osmo-bsc/bsc_subscr_conn_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/26011/1/src/osmo-bsc/bsc_subscr_conn_fsm.c@961 
PS1, Line 961: 	mgcp_client = osmo_mgcpc_ep_client(conn->user_plane.mgw_endpoint);
> Could it be that conn->user_plane. […]
Yes, it can, but osmo_mgcpc_ep_client and mgcp_client_pool_put are NULL pointer safe.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26011
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I5a7ce6a1880a1060df74d03dd4eb38b51fd85c69
Gerrit-Change-Number: 26011
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Oct 2021 17:23:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211028/d18803da/attachment.htm>


More information about the gerrit-log mailing list