Change in osmo-iuh[master]: hnbap: Use asn1c flag -fcompound-names to avoid name collisions with ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Oct 28 15:14:50 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/25991 )

Change subject: hnbap: Use asn1c flag -fcompound-names to avoid name collisions with other libs
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> I really wanted to avoid this when writing the original osmo-iuh code. Those names are just getting way too long.  Are we sure we really need includes of clashing names in the same source file?

I'd rather have a bit longer names than really having to waste hours playing tetris with header files and source files. Having these patches solves the build problems in osmo-hnodeb and whoever wishes to use this library. BTW, none of our code outside osmo-iuh really uses those structures being used, so nothing breaks, and we don't really care if they are longer because we don't use a lot of them in any place.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/25991
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I1bcbe047d233684647d6ffe9febb14a12c579696
Gerrit-Change-Number: 25991
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Oct 2021 15:14:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211028/16ec0d86/attachment.htm>


More information about the gerrit-log mailing list