This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/25985 ) Change subject: gbproxy: Route DL STATUS with BVCI on SIG-BVC ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-gbproxy/+/25985/1/src/gb_proxy.c File src/gb_proxy.c: https://gerrit.osmocom.org/c/osmo-gbproxy/+/25985/1/src/gb_proxy.c@1021 PS1, Line 1021: static int gbproxy_bvci_from_status_pdu(struct msgb *msg, struct tlv_parsed *tp, uint16_t *bvci, char *log_pfx) > Some small func description would be helpful here. […] good catch about msg, thanks. Will add comment here and for the tlli function above https://gerrit.osmocom.org/c/osmo-gbproxy/+/25985/1/src/gb_proxy.c@1527 PS1, Line 1527: if (bvci != 0) { > You can add this check inline with the other if: […] Ack https://gerrit.osmocom.org/c/osmo-gbproxy/+/25985/1/src/gb_proxy.c@1530 PS1, Line 1530: /* TODO: Log */ > Please add the log right now :) Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/25985 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I5928cebea7f39d6648f95dfa1a46437de202f723 Gerrit-Change-Number: 25985 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 28 Oct 2021 14:18:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211028/e3967356/attachment.htm>