This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/25959 ) Change subject: src/*/Makefile.am: Use asn1c -R to avoid generating runtime code ...................................................................... src/*/Makefile.am: Use asn1c -R to avoid generating runtime code Change-Id: I5666a6dc1ec9e56fe133642fb0054e913265c081 --- M src/hnbap/Makefile.am M src/ranap/Makefile.am M src/rua/Makefile.am M src/sabp/Makefile.am 4 files changed, 5 insertions(+), 13 deletions(-) Approvals: pespin: Looks good to me, approved; Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/src/hnbap/Makefile.am b/src/hnbap/Makefile.am index 7835bcd..79c0ac4 100644 --- a/src/hnbap/Makefile.am +++ b/src/hnbap/Makefile.am @@ -243,9 +243,7 @@ regen: regenerate-from-asn1-source regenerate-from-asn1-source: - asn1c -gen-PER -fnative-types $(HNBAP_ASN1)/HNBAP-CommonDataTypes.asn $(HNBAP_ASN1)/HNBAP-Constants.asn $(HNBAP_ASN1)/HNBAP-IEs.asn $(HNBAP_ASN1)/HNBAP-PDU.asn -# remove the local copy of the runtime code - -rm ANY.* BOOLEAN.* INTEGER.* NativeEnumerated.* NativeInteger.* OBJECT_IDENTIFIER.* asn_* OCTET_STRING.* converter-sample.c per_* xer_* constr* der_* ber_* BIT_STRING.* + asn1c -R -gen-PER -fnative-types $(HNBAP_ASN1)/HNBAP-CommonDataTypes.asn $(HNBAP_ASN1)/HNBAP-Constants.asn $(HNBAP_ASN1)/HNBAP-IEs.asn $(HNBAP_ASN1)/HNBAP-PDU.asn # change include style to `#include <dir/foo.h>' $(top_srcdir)/move-asn1-header-files.sh osmocom/hnbap $(ASN_MODULE_INC) # Finally copy *.c from buildir to srcdir: diff --git a/src/ranap/Makefile.am b/src/ranap/Makefile.am index 4ba3a79..d5dc4fc 100644 --- a/src/ranap/Makefile.am +++ b/src/ranap/Makefile.am @@ -1169,10 +1169,8 @@ regen: regenerate-from-asn1-source regenerate-from-asn1-source: - ASN1C_PREFIX="RANAP_" asn1c -gen-PER $(top_srcdir)/asn1/ranap/RANAP-CommonDataTypes.asn $(top_srcdir)/asn1/ranap/RANAP-Constants.asn $(top_srcdir)/asn1/ranap/RANAP-IEs.asn $(top_srcdir)/asn1/ranap/RANAP-PDU.asn - @rm ANY.* BOOLEAN.* INTEGER.* NativeEnumerated.* NativeInteger.* NULL.* OBJECT_IDENTIFIER.* asn_* OCTET_STRING.* converter-sample.c per_* xer_* constr* der_* ber_* BIT_STRING.* -# some fixups in erroneous code that asn1c generates - sed -i '6i#include <constr_CHOICE.h>' RANAP_ChosenEncryptionAlgorithm.h RANAP_ChosenIntegrityProtectionAlgorithm.h RANAP_IMSI.h RANAP_PLMNidentity.h RANAP_RAB-ReleaseFailedList.c RANAP_RAB-ReleaseList.c RANAP_RAB-SetupOrModifyList.c RANAP_ResetResourceList.c RANAP_ResetResourceAckList.c + ASN1C_PREFIX="RANAP_" asn1c -R -gen-PER $(top_srcdir)/asn1/ranap/RANAP-CommonDataTypes.asn $(top_srcdir)/asn1/ranap/RANAP-Constants.asn $(top_srcdir)/asn1/ranap/RANAP-IEs.asn $(top_srcdir)/asn1/ranap/RANAP-PDU.asn + sed -i '7i#include <constr_CHOICE.h>' RANAP_ChosenEncryptionAlgorithm.h RANAP_ChosenIntegrityProtectionAlgorithm.h RANAP_IMSI.h RANAP_PLMNidentity.h RANAP_RAB-ReleaseFailedList.c RANAP_RAB-ReleaseList.c RANAP_RAB-SetupOrModifyList.c RANAP_ResetResourceList.c RANAP_ResetResourceAckList.c sed -i 's/Member/MemberA/' RANAP_LA-LIST.[ch] sed -i 's/Member/MemberB/' RANAP_RABParametersList.[ch] sed -i 's/Member/MemberC/' RANAP_AuthorisedPLMNs.[ch] diff --git a/src/rua/Makefile.am b/src/rua/Makefile.am index c848639..493a466 100644 --- a/src/rua/Makefile.am +++ b/src/rua/Makefile.am @@ -81,9 +81,7 @@ regen: regenerate-from-asn1-source regenerate-from-asn1-source: - ASN1C_PREFIX="RUA_" asn1c -gen-PER $(top_srcdir)/asn1/rua/RUA-CommonDataTypes.asn $(top_srcdir)/asn1/rua/RUA-Constants.asn $(top_srcdir)/asn1/rua/RUA-IEs.asn $(top_srcdir)/asn1/rua/RUA-PDU.asn -# remove the local copy of the runtime code - @rm ANY.* BOOLEAN.* INTEGER.* NativeEnumerated.* NativeInteger.* OBJECT_IDENTIFIER.* asn_* OCTET_STRING.* converter-sample.c per_* xer_* constr* der_* ber_* BIT_STRING.* + ASN1C_PREFIX="RUA_" asn1c -R -gen-PER $(top_srcdir)/asn1/rua/RUA-CommonDataTypes.asn $(top_srcdir)/asn1/rua/RUA-Constants.asn $(top_srcdir)/asn1/rua/RUA-IEs.asn $(top_srcdir)/asn1/rua/RUA-PDU.asn # change include style to `#include <dir/foo.h>' $(top_srcdir)/move-asn1-header-files.sh osmocom/rua $(ASN_MODULE_INC) # Finally copy *.c from buildir to srcdir: diff --git a/src/sabp/Makefile.am b/src/sabp/Makefile.am index 5e1b557..faace13 100644 --- a/src/sabp/Makefile.am +++ b/src/sabp/Makefile.am @@ -135,9 +135,7 @@ regen: regenerate-from-asn1-source regenerate-from-asn1-source: - ASN1C_PREFIX="SABP_" asn1c -gen-PER $(top_srcdir)/asn1/sabp/SABP-CommonDataTypes.asn $(top_srcdir)/asn1/sabp/SABP-Constants.asn $(top_srcdir)/asn1/sabp/SABP-IEs.asn $(top_srcdir)/asn1/sabp/SABP-PDU.asn -# remove the local copy of the runtime code - @rm ANY.* INTEGER.* NativeEnumerated.* NativeInteger.* asn_* OCTET_STRING.* converter-sample.c per_* xer_* constr* der_* ber_* BIT_STRING.* + ASN1C_PREFIX="SABP_" asn1c -R -gen-PER $(top_srcdir)/asn1/sabp/SABP-CommonDataTypes.asn $(top_srcdir)/asn1/sabp/SABP-Constants.asn $(top_srcdir)/asn1/sabp/SABP-IEs.asn $(top_srcdir)/asn1/sabp/SABP-PDU.asn # change include style to `#include <dir/foo.h>' sed -i 's/Member/MemberA/' SABP_MessageStructure.[ch] sed -i 's/Member/MemberB/' SABP_Criticality-Diagnostics.[ch] -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/25959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I5666a6dc1ec9e56fe133642fb0054e913265c081 Gerrit-Change-Number: 25959 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211027/10c82e38/attachment.htm>