This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/25931 ) Change subject: varaible for atoi() result shouild be signed integer ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-cbc/+/25931/1/src/rest_api.c File src/rest_api.c: https://gerrit.osmocom.org/c/osmo-cbc/+/25931/1/src/rest_api.c@605 PS1, Line 605: int message_id; > so iirc there's another patch from Vadim now in gerrit simply dropping the "message_id < 0" check from line 614. Please agree on which one to merge. Unfortunately, we both attempted to fix the same issue. I abandoned my patch. > perhaps atoi() can return negative if there's an error? No, atoi() does not detect errors at all. > It may be a good place to use neel's recent APIs to read integers from string using libosmocore. I don't see the need for this complication... -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/25931 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I650fce5bd64752823ee57d8b528d2b371fada857 Gerrit-Change-Number: 25931 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 26 Oct 2021 15:15:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211026/8b08b8ca/attachment.htm>