Change in osmo-ttcn3-hacks[master]: bsc: Introduce test TC_dyn_ts_sdcch8_all_subslots_used

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Oct 26 14:37:12 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25938 )

Change subject: bsc: Introduce test TC_dyn_ts_sdcch8_all_subslots_used
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25938/1/bsc/BSC_Tests.ttcn 
File bsc/BSC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25938/1/bsc/BSC_Tests.ttcn@1675 
PS1, Line 1675: function f_est_dchan_dyn(OCT1 ra, GsmFrameNumber fn, octetstring l3)
A comment here would be useful to understand the difference from f_est_dchan().


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25938/1/bsc/BSC_Tests.ttcn@7300 
PS1, Line 7300: SDCCH
Might be good to clarify that it's SDCCH/4+CBCH.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25938/1/bsc/BSC_Tests.ttcn@7308 
PS1, Line 7308: Three dyn TS as well as one static TCH/F and one TCH/H timeslot are available
Hmm, but above you re-configure all timeslots to PDCH... This looks confusing.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25938
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iee37eef2012ce2c2e2f0a0db4c26abb75a947d84
Gerrit-Change-Number: 25938
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Oct 2021 14:37:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211026/e2583f73/attachment.htm>


More information about the gerrit-log mailing list