This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25942 ) Change subject: bts-trx: sched: tx_pdtch_fn: Handle PCU idle blocks properly ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/25942/1/src/osmo-bts-trx/sched_lchan_pdtch.c File src/osmo-bts-trx/sched_lchan_pdtch.c: https://gerrit.osmocom.org/c/osmo-bts/+/25942/1/src/osmo-bts-trx/sched_lchan_pdtch.c@165 PS1, Line 165: || !msg->l2h > Are you sure there would be no NULL pointer dereference if msg is NULL? "if !msg" is first, hence if it holds true it enters directly the if clause and "!msg->l2h" is not executed. So yes, that' fine. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25942 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I57e215fedeb415db4e67fdc56bf0f1410b5f7130 Gerrit-Change-Number: 25942 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Mon, 25 Oct 2021 15:25:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211025/4f82760a/attachment.htm>