This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20296 ) Change subject: logging: Change stderr + file target to use non-blocking write ...................................................................... Patch Set 15: Code-Review+1 (3 comments) LGTM, just some nitpicks https://gerrit.osmocom.org/c/libosmocore/+/20296/15/src/logging.c File src/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/20296/15/src/logging.c@920 PS15, Line 920: fprintf(target->tgt_file.out, "%s", log); how about: fputs(log, target->tgt_file.out) https://gerrit.osmocom.org/c/libosmocore/+/20296/15/src/logging.c@1084 PS15, Line 1084: /* close the write queue file descriptor */ With this comment, I would have expected close() here - but that's happening only later on. Maybe remove the comment here, and change "re-open" to "open" below? https://gerrit.osmocom.org/c/libosmocore/+/20296/15/src/logging.c@1099 PS15, Line 1099: block write? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia58fd78535c41b3da3aeb7733aadc785ace610da Gerrit-Change-Number: 20296 Gerrit-PatchSet: 15 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 25 Oct 2021 10:22:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211025/b3388bbb/attachment.htm>