Change in libusrp[master]: usrp_standard: fix out-of-bounds read in set_rx_freq()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Oct 25 10:03:06 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libusrp/+/25925 )

Change subject: usrp_standard: fix out-of-bounds read in set_rx_freq()
......................................................................

usrp_standard: fix out-of-bounds read in set_rx_freq()

Change-Id: I3e3ba31e5a68f92a330c5791ee72ad1ffab83da9
Fixes: CID#240737
---
M host/lib/usrp_standard.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved
  laforge: Looks good to me, but someone else must approve



diff --git a/host/lib/usrp_standard.cc b/host/lib/usrp_standard.cc
index fe5afab..69145ab 100644
--- a/host/lib/usrp_standard.cc
+++ b/host/lib/usrp_standard.cc
@@ -649,7 +649,7 @@
 bool
 usrp_standard_rx::set_rx_freq (int channel, double freq)
 {
-  if (channel < 0 || channel > MAX_CHAN)
+  if (channel < 0 || channel >= MAX_CHAN)
     return false;
 
   unsigned int v =

-- 
To view, visit https://gerrit.osmocom.org/c/libusrp/+/25925
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libusrp
Gerrit-Branch: master
Gerrit-Change-Id: I3e3ba31e5a68f92a330c5791ee72ad1ffab83da9
Gerrit-Change-Number: 25925
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211025/1fdfd999/attachment.htm>


More information about the gerrit-log mailing list