Change in osmo-msc[master]: smpp_smsc: use osmo_talloc_replace_string() in smpp_smsc_conf()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Oct 25 09:16:22 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25930 )

Change subject: smpp_smsc: use osmo_talloc_replace_string() in smpp_smsc_conf()
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-msc/+/25930/1/src/libmsc/smpp_smsc.c 
File src/libmsc/smpp_smsc.c:

https://gerrit.osmocom.org/c/osmo-msc/+/25930/1/src/libmsc/smpp_smsc.c@990 
PS1, Line 990: 	osmo_talloc_replace_string(&smsc->bind_addr, bind_addr);
You are missing the ctx param here: osmo_talloc_replace_string(smsc, &smsc->bind_addr, bind_addr);



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25930
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie3dc0d9673a0410a5908cba77fc352d581bac6f6
Gerrit-Change-Number: 25930
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Oct 2021 09:16:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211025/7e4747bc/attachment.htm>


More information about the gerrit-log mailing list