Change in osmo-trx[master]: IPCDevice: check value returned from select()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sun Oct 24 19:48:20 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/25923 )


Change subject: IPCDevice: check value returned from select()
......................................................................

IPCDevice: check value returned from select()

Change-Id: I1c823317659547bb2391c57ac4d7931de1a383e3
Fxies: CID#240744
---
M Transceiver52M/device/ipc/IPCDevice.cpp
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/23/25923/1

diff --git a/Transceiver52M/device/ipc/IPCDevice.cpp b/Transceiver52M/device/ipc/IPCDevice.cpp
index 5ed428e..752a2d0 100644
--- a/Transceiver52M/device/ipc/IPCDevice.cpp
+++ b/Transceiver52M/device/ipc/IPCDevice.cpp
@@ -849,7 +849,10 @@
 			FD_SET(curr_fd->fd, &cwfds);
 	}
 
-	select(max_fd + 1, &crfds, &cwfds, 0, &wait);
+	if (select(max_fd + 1, &crfds, &cwfds, 0, &wait) < 0) {
+		LOGP(DDEV, LOGL_ERROR, "select() failed: %s\n", strerror(errno));
+		return;
+	}
 
 	for (unsigned int i = 0; i < chans; i++) {
 		int flags = 0;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/25923
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1c823317659547bb2391c57ac4d7931de1a383e3
Gerrit-Change-Number: 25923
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211024/0252bac8/attachment.htm>


More information about the gerrit-log mailing list