Change in libosmocore[master]: gsm_08_58: extend struct abis_rsl_osmo_temp_ovp_acch_cap

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Oct 24 08:33:39 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25866 )

Change subject: gsm_08_58: extend struct abis_rsl_osmo_temp_ovp_acch_cap
......................................................................

gsm_08_58: extend struct abis_rsl_osmo_temp_ovp_acch_cap

This change adds new [bit-]fields in order to allow:

  * selectively enabling SACCH and/or FACCH,
  * setting the RxQual (BER) threshold.

Change-Id: Ia28293a12de0af71f55e701fb65c46e905dae217
Related: SYS#5319
---
M include/osmocom/gsm/protocol/gsm_08_58.h
1 file changed, 11 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/include/osmocom/gsm/protocol/gsm_08_58.h b/include/osmocom/gsm/protocol/gsm_08_58.h
index fd22d91..b46f9f5 100644
--- a/include/osmocom/gsm/protocol/gsm_08_58.h
+++ b/include/osmocom/gsm/protocol/gsm_08_58.h
@@ -141,7 +141,17 @@
 
 /* Osmocom specific IE to negotiate temporary overpower of ACCH channels */
 struct abis_rsl_osmo_temp_ovp_acch_cap {
-	uint8_t overpower_db;
+#if OSMO_IS_BIG_ENDIAN
+	uint8_t sacch_enable:1,
+		facch_enable:1,
+		rxqual:3,
+		overpower_db:3;
+#elif OSMO_IS_LITTLE_ENDIAN
+	uint8_t overpower_db:3,
+		rxqual:3,
+		facch_enable:1,
+		sacch_enable:1;
+#endif
 } __attribute__ ((packed));
 
 /* Chapter 9.1 */

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25866
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia28293a12de0af71f55e701fb65c46e905dae217
Gerrit-Change-Number: 25866
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211024/cebc88aa/attachment.htm>


More information about the gerrit-log mailing list