Change in osmo-ci[master]: coverity: allow passing configure args to build_default()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Oct 24 08:30:52 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25856 )

Change subject: coverity: allow passing configure args to build_default()
......................................................................

coverity: allow passing configure args to build_default()

Change-Id: I79aa2c65cd0d3b06c0bd9ec4f44288b21e40c3b7
---
M coverity/build_Osmocom.sh
1 file changed, 9 insertions(+), 17 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh
index fb5ed81..2e00273 100755
--- a/coverity/build_Osmocom.sh
+++ b/coverity/build_Osmocom.sh
@@ -20,7 +20,8 @@
 
 build_default() {
 	pushd $1
-	do_build
+	shift
+	do_build $*
 	popd
 }
 
@@ -38,20 +39,6 @@
 	popd
 }
 
-build_osmobts() {
-	pushd osmo-bts
-
-	do_build --enable-sysmocom-bts --with-sysmobts="$prefix/include/" --enable-trx
-	popd
-}
-
-build_osmopcu() {
-	pushd osmo-pcu
-
-	do_build --enable-sysmocom-dsp=yes --with-sysmobts="$prefix/include/"
-	popd
-}
-
 build_osmocombb() {
 	pushd osmocom-bb/src/
 	make nofirmware
@@ -72,8 +59,13 @@
 build_default libsmpp34
 build_default osmo-ggsn
 build_default osmo-iuh
-build_osmopcu
-build_osmobts
+build_default osmo-pcu \
+	--with-sysmobts="$prefix/include/" \
+	--enable-sysmocom-dsp=yes
+build_default osmo-bts \
+	--with-sysmobts="$prefix/include/" \
+	--enable-sysmocom-bts \
+	--enable-trx
 build_default osmo-sysmon
 build_default osmo-mgw
 build_default osmo-bsc

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/25856
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I79aa2c65cd0d3b06c0bd9ec4f44288b21e40c3b7
Gerrit-Change-Number: 25856
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211024/c4b40893/attachment.htm>


More information about the gerrit-log mailing list