This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25869 ) Change subject: [overpower] VTY: add more ACCH overpower related parameters ...................................................................... Patch Set 3: (3 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/25869/3/src/osmo-bsc/bts_vty.c File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25869/3/src/osmo-bsc/bts_vty.c@721 PS3, Line 721: "rxqual (0|1|2|3|4|5|6|7)" > I wonder why isn't this specified as <0-7> (I know it's not related to this patch, but anyway). Because with '<0-7>' we would not be able to describe every possible value. https://gerrit.osmocom.org/c/osmo-bsc/+/25869/3/src/osmo-bsc/bts_vty.c@724 PS3, Line 724: "BER >= 0% (always on)\n" \ > if changed above, this can be rewritten to simply point to the 3GPP TS where this table is specified […] I personally find it useful to have the exact 'BER >= x' bands in the interactive VTY help. This way there is no need to open the specs. and look up every value... https://gerrit.osmocom.org/c/osmo-bsc/+/25869/3/src/osmo-bsc/bts_vty.c@4309 PS3, Line 4309: mode, top->overpower_db, VTY_NEWLINE); > what if mode is NULL here? top->sacch and top->facch being false. This should not happen (see cfg_bts_top_dl_acch_cmd below). If 'overpower_db > 0' is true, then at least one of top->sacch / top->facch shall be true. I can add an ASSERT here, just to be safe. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25869 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia2e01e11d718ea0ba2a7e49ae2b871d57991f31c Gerrit-Change-Number: 25869 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 21 Oct 2021 18:22:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211021/d4445797/attachment.htm>