This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25850 ) Change subject: fix bootloader led config crash ...................................................................... fix bootloader led config crash This led to occasional crashes for targets with leds since it was introduced 3 years ago The interesting thing is that most of the time it didn't crash... Change-Id: Ia6a1b1fc0e44a301b4fb1d9c9fdbc27d61dcab97 --- M firmware/apps/dfu/main.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/firmware/apps/dfu/main.c b/firmware/apps/dfu/main.c index f8c0c53..d5a6fa6 100644 --- a/firmware/apps/dfu/main.c +++ b/firmware/apps/dfu/main.c @@ -271,7 +271,7 @@ #ifdef PINS_LEDS /* Configure LED */ - PIO_Configure(pinsLeds, sizeof(pinsLeds)); + PIO_Configure(pinsLeds, PIO_LISTSIZE(pinsLeds)); PIO_Set(&pinsLeds[LED_NUM_RED]); PIO_Clear(&pinsLeds[LED_NUM_GREEN]); #endif -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25850 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ia6a1b1fc0e44a301b4fb1d9c9fdbc27d61dcab97 Gerrit-Change-Number: 25850 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211020/01a7e85a/attachment.htm>