This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25825 ) Change subject: gsm_pchan2chan_nr(): Properly assert if unexpected pchan is passed ...................................................................... gsm_pchan2chan_nr(): Properly assert if unexpected pchan is passed A bit of archeology, history & recap: ec1b5a0e9e2b6549e0ede48e803095e569997355 (openbsc.git) Adds assert in gsm_ts2chan_nr() 2f44693fad8505255293d3ed37dbd4e7cabebd37 (openbsc.git) ASSERT is disabled due to reported hit in octphy and litecell in gerrit for ec1b5a0e9e2b6549e0ede48e803095e569997355 5cef0623ef64bc641d2d29edb1ebaaafcc7c0df6 (osmo-bts,git) minor fixes to gsm_ts2chan_nr() regarding the pragma c9079d91069eaadf181a6e26e3c7205f1f05cbda (osmo-bts.git) GSM_PCHAN_NONE case is introduced in gsm_ts2chan_nr() This code has long evolved and robustness has improved, it's not even part of openbsc.git for several years now. Let's always assert if we receive an unexpected value there, since they are all internally handled values and hence we have control over them. Related: OS#2906 Change-Id: I25e2cf0c922bc9902336e9add75a47535b9355bf --- M src/common/lchan.c 1 file changed, 1 insertion(+), 8 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/lchan.c b/src/common/lchan.c index a3be4ee..e532615 100644 --- a/src/common/lchan.c +++ b/src/common/lchan.c @@ -364,14 +364,7 @@ default: LOGP(DRSL, LOGL_ERROR, "Physical channel %s (0x%02x) not expected!\n", gsm_pchan_name(pchan), (int)pchan); - /* OSMO_ASSERT(lchan_nr == 0); - * FIXME: On octphy and litecell, we hit above assertion (see - * Max's comment at https://gerrit.osmocom.org/589 ); disabled - * for BTS until this is clarified; remove the #ifdef when it - * is fixed. Tracked in OS#2906. - */ -#pragma message "fix caller that passes lchan_nr != 0" - cbits = 0x10; + OSMO_ASSERT(0); break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25825 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I25e2cf0c922bc9902336e9add75a47535b9355bf Gerrit-Change-Number: 25825 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211020/0318a975/attachment.htm>