This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25820 ) Change subject: tbf: update(): return negative val on error ...................................................................... tbf: update(): return negative val on error Let's follow usual convention where errors are returned as negative values. Change-Id: Ib4f4dc37ae82ba8efdc212ed85af7934e16a8a8d --- M src/tbf.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/tbf.cpp b/src/tbf.cpp index 3e190b4..50940c8 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -323,7 +323,7 @@ if (rc < 0) { LOGPTBF(this, LOGL_ERROR, "No resource after update???\n"); bts_do_rate_ctr_inc(bts, CTR_TBF_ALLOC_FAIL); - return -rc; + return rc; } if (is_egprs_enabled()) { -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25820 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib4f4dc37ae82ba8efdc212ed85af7934e16a8a8d Gerrit-Change-Number: 25820 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211019/e47148b8/attachment.htm>