Change in osmo-pcu[master]: tbf_fsm: Add assert verifying X2002 only triggers for DL TBF

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Oct 19 11:41:54 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25817 )

Change subject: tbf_fsm: Add assert verifying X2002 only triggers for DL TBF
......................................................................

tbf_fsm: Add assert verifying X2002 only triggers for DL TBF

Code above setting the timer in same tbf_fsm already has this kind of
assert, but it helps understanding the code having this assert here.

Change-Id: I7588deef5073694eb5fecdb516c241a04594e2b0
---
M src/tbf_fsm.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  dexter: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/tbf_fsm.c b/src/tbf_fsm.c
index fb947b2..af2b34e 100644
--- a/src/tbf_fsm.c
+++ b/src/tbf_fsm.c
@@ -352,6 +352,9 @@
 {
 	struct gprs_rlcmac_dl_tbf *dl_tbf = as_dl_tbf(ctx->tbf);
 
+	/* X2002 is used only for DL TBF */
+	OSMO_ASSERT(dl_tbf);
+
 	if (ctx->fi->state == TBF_ST_ASSIGN) {
 		tbf_assign_control_ts(ctx->tbf);
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25817
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7588deef5073694eb5fecdb516c241a04594e2b0
Gerrit-Change-Number: 25817
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211019/6e8607de/attachment.htm>


More information about the gerrit-log mailing list