Change in pysim[master]: pySim-shell: add bulk provisioning support

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Oct 19 11:08:38 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25552 )

Change subject: pySim-shell: add bulk provisioning support
......................................................................


Patch Set 10: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/25552/10/pySim-shell.py 
File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/25552/10/pySim-shell.py@226 
PS10, Line 226: 		self.poutput("\033[91m")
I would have expected to use cmd2.ansi rather than hard-coded sequences here (https://cmd2.readthedocs.io/en/latest/api/ansi.html#module-cmd2.ansi) but this is not a blocker.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/25552
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9e4926675c5a497a22fc6a4fefdd388fe18a2b2d
Gerrit-Change-Number: 25552
Gerrit-PatchSet: 10
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Oct 2021 11:08:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211019/395cb6bd/attachment.htm>


More information about the gerrit-log mailing list