Change in osmo-msc[master]: Add support for LCLS to the MSC

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

keith gerrit-no-reply at lists.osmocom.org
Mon Oct 18 20:05:36 UTC 2021


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/24236 )

Change subject: Add support for LCLS to the MSC
......................................................................


Patch Set 7:

(1 comment)

> Patch Set 7: Code-Review+1
> 
> (3 comments)
> 
> it would be nice to have the MNCC protocol version change in a separate patch, so that it is easy to read what parts relate to the bare protocol change, and what parts relate to functional change in osmo-msc

The protocol change is 3 lines in mncc.h (in fact the commit would just be mncc.h from this patchset and nothing else. I can do it, but does it really make a difference?

https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/include/osmocom/msc/mncc.h 
File include/osmocom/msc/mncc.h:

https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/include/osmocom/msc/mncc.h@164 
PS7, Line 164: 	struct osmo_gcr_parsed gcr;
> this is a good place, besides the SDP always being in the end, this leaves previous version MNCC unc […]
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/24236
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I705c860e51637b4537cad65a330ecbaaca96dd5b
Gerrit-Change-Number: 24236
Gerrit-PatchSet: 7
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Assignee: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Oct 2021 20:05:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211018/c87de0d6/attachment.htm>


More information about the gerrit-log mailing list