Change in osmo-pcu[master]: bts_rcv_rach(): Split code paths for Ass and Ass Rej

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Oct 18 12:57:15 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25813 )

Change subject: bts_rcv_rach(): Split code paths for Ass and Ass Rej
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/25813/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-pcu/+/25813/1//COMMIT_MSG@9 
PS1, Line 9: a lot easier to follow
I would not say it's hard to follow the current variant of this function. Please add more arguments why. Currently it feels like you're refactoring the code to satisfy your personal/subjective coding preferences.


https://gerrit.osmocom.org/c/osmo-pcu/+/25813/1/src/bts.cpp 
File src/bts.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/25813/1/src/bts.cpp@870 
PS1, Line 870: 	struct gprs_rlcmac_pdch *pdch;
Unrelated change.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25813
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I80e554315d36a515a7edc9ae51057ce31eb9110d
Gerrit-Change-Number: 25813
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Oct 2021 12:57:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211018/10dd180b/attachment.htm>


More information about the gerrit-log mailing list