Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_ul_tbf_reestablish_with_pkt_resource_req_n3105...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Oct 16 09:23:44 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25806 )

Change subject: pcu: Introduce test TC_ul_tbf_reestablish_with_pkt_resource_req_n3105_max
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25806/1/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25806/1/pcu/PCU_Tests.ttcn@3120 
PS1, Line 3120: 	BTS.send(ts_PCUIF_RTS_REQ(nr.bts_nr, nr.trx_nr, nr.ts_nr,
We definitely need something like f_pcuif_send_rts().


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25806/1/pcu/PCU_Tests.ttcn@3132 
PS1, Line 3132: nr := ts_TsTrxBtsNum
Why are you doing this? The value does not change, so it makes no sense to execute this template again and again.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25806/1/pcu/PCU_Tests.ttcn@3148 
PS1, Line 3148: nr := ts_TsTrxBtsNum
Same here.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25806/1/pcu/PCU_Tests.ttcn@3160 
PS1, Line 3160: nr := ts_TsTrxBtsNum
Same here.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25806
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3a50445c707430900c78623c7093ff7eb1f3ed95
Gerrit-Change-Number: 25806
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Sat, 16 Oct 2021 09:23:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211016/8ec0f80e/attachment.htm>


More information about the gerrit-log mailing list