This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/25794 ) Change subject: ts_51_011: fix select response decoder ...................................................................... ts_51_011: fix select response decoder The select response decoder is using b2h() wrongly. b2h expects a bytearray but we call it with an integer. In the following two lines we try to convert an integer to an integer. Change-Id: Ib6448d3bd7a0dc7f25e5ee82a42266b3313e2a95 --- M pySim/ts_51_011.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 70629f7..5d1197c 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -937,9 +937,9 @@ file_type = type_of_file_map[resp_bin[6]] if resp_bin[6] in type_of_file_map else resp_bin[6] ret['file_descriptor']['file_type'] = file_type if file_type in ['mf', 'df']: - ret['file_characteristics'] = b2h(resp_bin[13]) - ret['num_direct_child_df'] = int(resp_bin[14], 16) - ret['num_direct_child_ef'] = int(resp_bin[15], 16) + ret['file_characteristics'] = b2h(resp_bin[13:14]) + ret['num_direct_child_df'] = resp_bin[14] + ret['num_direct_child_ef'] = resp_bin[15] ret['num_chv_unblock_adm_codes'] = int(resp_bin[16]) # CHV / UNBLOCK CHV stats elif file_type in ['working_ef']: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25794 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib6448d3bd7a0dc7f25e5ee82a42266b3313e2a95 Gerrit-Change-Number: 25794 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211015/e82314e9/attachment.htm>