This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25800 ) Change subject: tbf: Drop pending polls during free also on states != ASSIGN ...................................................................... tbf: Drop pending polls during free also on states != ASSIGN The situation holds true as long as the assignment is resolved. Hence, it can also happen that the TBF is in RELEASE state, because it was unable to do the assignment (and after retrying, MAX_N3105 moved it into RELEASING). Let's not explicitly check states, the other conditions should be enough. Related: SYS#5647 Change-Id: I05fb0ea44aeb3fbda9e8e1c449e9366efaa2c511 --- M src/tbf.cpp 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/00/25800/1 diff --git a/src/tbf.cpp b/src/tbf.cpp index 0331a80..2343862 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -245,11 +245,12 @@ /* During assignment (state=ASSIGN), tbf may be temporarily using * tbf->control_ts from a previous TBF/SBA to transmit the UL/DL - * Assignment, which may not be necessarly be a TS where the current TBF - * is attached to. Hence, we may have ULC pollings ongoing and we need - * to make sure we drop all reserved nodes there: */ - if (tbf_state(tbf) == TBF_ST_ASSIGN && - tbf->control_ts != TBF_CONTROL_TS_UNSET && !tbf->pdch[tbf->control_ts]) + * Assignment, which may not be necessarily be a TS where the current TBF + * is attached to. This will be the case until a TBF receives proper + * confirmation from the MS and goes through the FLOW state. Hence, we + * may have ULC pollings ongoing and we need to make sure we drop all + * reserved nodes there: */ + if (tbf->control_ts != TBF_CONTROL_TS_UNSET && !tbf->pdch[tbf->control_ts]) pdch_ulc_release_tbf(tbf->trx->pdch[tbf->control_ts].ulc, tbf); /* Now simply detach from all attached PDCHs */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25800 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I05fb0ea44aeb3fbda9e8e1c449e9366efaa2c511 Gerrit-Change-Number: 25800 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211014/fd0b667b/attachment.htm>