Change in osmo-bts[master]: lchan: Avoid applying transition changes if state new==old

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Oct 14 14:38:01 UTC 2021


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/25788 )


Change subject: lchan: Avoid applying transition changes if state new==old
......................................................................

lchan: Avoid applying transition changes if state new==old

This should just not happen, but in case it does, let's make sure we
don't run over unexpected paths.

Change-Id: I1ca86aa846084f53751076643665cb6dabc26a06
---
M src/common/lchan.c
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/88/25788/1

diff --git a/src/common/lchan.c b/src/common/lchan.c
index c4f3a47..99c452b 100644
--- a/src/common/lchan.c
+++ b/src/common/lchan.c
@@ -260,6 +260,10 @@
 	LOGPLCHAN(lchan, DL1C, LOGL_INFO, "state %s -> %s\n",
 	       gsm_lchans_name(lchan->state),
 	       gsm_lchans_name(state));
+
+	if (lchan->state == state)
+		return;
+
 	lchan->state = state;
 
 	/* Early Immediate Assignment: if we have a cached early IA pending, send it upon becoming active, or discard it

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25788
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1ca86aa846084f53751076643665cb6dabc26a06
Gerrit-Change-Number: 25788
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211014/b8951f0e/attachment.htm>


More information about the gerrit-log mailing list