Change in pysim[master]: cat: Fix SMS/ENVELOPE related IE tag definitions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Oct 14 14:05:59 UTC 2021


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/25783 )


Change subject: cat: Fix SMS/ENVELOPE related IE tag definitions
......................................................................

cat: Fix SMS/ENVELOPE related IE tag definitions

Change-Id: I7ed4d78479b6ff75cde20cb5b0bd1672035806ff
---
M pySim/cat.py
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/83/25783/1

diff --git a/pySim/cat.py b/pySim/cat.py
index 27065ee..00658de 100644
--- a/pySim/cat.py
+++ b/pySim/cat.py
@@ -52,7 +52,7 @@
                         'command_qualifier'/Int8ub)
 
 # TS 102 223 Section 8.7
-class DeviceIdentities(COMPR_TLV_IE, tag=0x02):
+class DeviceIdentities(COMPR_TLV_IE, tag=0x82):
     DEV_IDS = bidict({
         0x01: 'keypad',
         0x02: 'display',
@@ -126,8 +126,8 @@
 
 
 # TS 102 223 Section 8.13  + TS 31.111 Section 8.13
-class SMS_TPDU(COMPR_TLV_IE, tag=0x0B):
-    pass
+class SMS_TPDU(COMPR_TLV_IE, tag=0x8B):
+    _construct = Struct('tpdu'/HexAdapter(GreedyBytes))
 
 # TS 102 223 Section 8.15
 class TextString(COMPR_TLV_IE, tag=0x0d):

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/25783
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7ed4d78479b6ff75cde20cb5b0bd1672035806ff
Gerrit-Change-Number: 25783
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211014/632ddd40/attachment.htm>


More information about the gerrit-log mailing list