This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/25723 ) Change subject: cards: remove "auto_once" from possible ctype options ...................................................................... cards: remove "auto_once" from possible ctype options The card_detect function in cards.py allows to specify the card type or use the hints "auto" and "auto_once" to trigger autodetection of the card. However, "auto_once" has no effect and is not used by any caller, so lets remove it. Change-Id: Iea726f51e5ddb43d8a4da2672552fff38e29b006 --- M pySim/cards.py 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/pySim/cards.py b/pySim/cards.py index 2f96ee1..95352ff 100644 --- a/pySim/cards.py +++ b/pySim/cards.py @@ -1564,7 +1564,7 @@ card = None ctypes = dict([(kls.name, kls) for kls in _cards_classes]) - if ctype in ("auto", "auto_once"): + if ctype == "auto": for kls in _cards_classes: card = kls.autodetect(scc) if card: @@ -1576,9 +1576,6 @@ print("Autodetection failed") return None - if ctype == "auto_once": - ctype = card.name - elif ctype in ctypes: card = ctypes[ctype](scc) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25723 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iea726f51e5ddb43d8a4da2672552fff38e29b006 Gerrit-Change-Number: 25723 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211014/ee82c773/attachment.htm>