Change in libosmocore[master]: ns2: correct parse a BLOCK PDU which was received over a different NSVC

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Wed Oct 13 20:13:09 UTC 2021


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25558 )

Change subject: ns2: correct parse a BLOCK PDU which was received over a different NSVC
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/25558/3/src/gb/gprs_ns2_vc_fsm.c 
File src/gb/gprs_ns2_vc_fsm.c:

https://gerrit.osmocom.org/c/libosmocore/+/25558/3/src/gb/gprs_ns2_vc_fsm.c@a388 
PS3, Line 388: 			ns2_tx_unblock_ack(priv->nsvc);
> So you are now doing the opposite of what I advised to existent code! damn you hate me so much!
I like you. There also cake in the kitchen!


https://gerrit.osmocom.org/c/libosmocore/+/25558/4/src/gb/gprs_ns2_vc_fsm.c 
File src/gb/gprs_ns2_vc_fsm.c:

https://gerrit.osmocom.org/c/libosmocore/+/25558/4/src/gb/gprs_ns2_vc_fsm.c@909 
PS4, Line 909: 			} else if (nsh->pdu_type == NS_PDUT_BLOCK || nsh->pdu_type == NS_PDUT_STATUS) {
> looks like using a switch statement here over nsh->pty_type would be cleaner.
I'll do it in a following patch.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25558
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I483e3a1d3b8c43bbb0cc6185b7f7f772bcb264bf
Gerrit-Change-Number: 25558
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 13 Oct 2021 20:13:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211013/abb4d3a2/attachment.htm>


More information about the gerrit-log mailing list