This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25770 ) Change subject: tbf: Use define to flag control_ts unset special value ...................................................................... tbf: Use define to flag control_ts unset special value Change-Id: Idd3ccec509b40b6229544b45e54da1142805b6f9 --- M src/tbf.cpp M src/tbf.h 2 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/70/25770/1 diff --git a/src/tbf.cpp b/src/tbf.cpp index 7ebd268..153ba80 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -96,7 +96,7 @@ trx(NULL), first_ts(0), first_common_ts(0), - control_ts(0xff), + control_ts(TBF_CONTROL_TS_UNSET), fT(0), num_fT_exp(0), upgrade_to_multislot(false), @@ -328,7 +328,7 @@ int tbf_assign_control_ts(struct gprs_rlcmac_tbf *tbf) { - if (tbf->control_ts == 0xff) + if (tbf->control_ts == TBF_CONTROL_TS_UNSET) LOGPTBF(tbf, LOGL_INFO, "Setting Control TS %d\n", tbf->first_common_ts); else if (tbf->control_ts != tbf->first_common_ts) diff --git a/src/tbf.h b/src/tbf.h index 3aaf9fb..05beed5 100644 --- a/src/tbf.h +++ b/src/tbf.h @@ -116,6 +116,8 @@ #define GPRS_RLCMAC_FLAG_TO_DL_ACK 3 /* DL TBF: Failed to receive last polled DL ACK/NACK */ #define GPRS_RLCMAC_FLAG_TO_MASK 0xf0 /* timeout bits */ +#define TBF_CONTROL_TS_UNSET 0xff + #define T_START(tbf, t, T, r, f) tbf->t_start(t, T, r, f, __FILE__, __LINE__) #ifdef __cplusplus -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25770 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Idd3ccec509b40b6229544b45e54da1142805b6f9 Gerrit-Change-Number: 25770 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211013/5001311f/attachment.htm>