Change in libosmocore[master]: ratectr: make atomic

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Oct 12 16:20:19 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25414 )

Change subject: ratectr: make atomic
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> I'm not sure if this is really the way to go and whether it makes sense (I'm not saying the opposite either). This basically makes rate_ctr groups created in one thread unavailable/invsible to other threads. Which means, for instance, if the user uses the VTY to show the rate counters, only the ones attached to the thread checking the VTY would be displayed/accessible.
> 
> An alternative would be doing something like it's done in osmo-trx iirc. counters are copied from one thread to another without critical section, and only updated from within main thread.

I share Pau's concerns.  Not sure how much we want to modify libosmocore fundamentals just for one odd mgw use case.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25414
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I117f89add4798a250b5758543f1fb3e01d974205
Gerrit-Change-Number: 25414
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 12 Oct 2021 16:20:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211012/5510075f/attachment.htm>


More information about the gerrit-log mailing list