Change in osmo-bsc[master]: bts: set ncc_permitted from bts_alloc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Wed Oct 13 03:44:33 UTC 2021


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25765 )


Change subject: bts: set ncc_permitted from bts_alloc
......................................................................

bts: set ncc_permitted from bts_alloc

The value ncc_permitted is preset in osmo_bsc_main.c from
bootstrap_bts(). It is a constant value that also cannot be changed via
the VTY. Therefore it should be set from bts_alloc(). This also fixes
the problem that when the BTS is added at runtime from the VTY. BTSs
added at runtime would have an all zero ncc_permitted until the next
restart of osmo_bsc.

Change-Id: I9f02277d7b4b4bcb383e749435416a0b22efd5e8
Related: SYS#5369
---
M src/osmo-bsc/bts.c
M src/osmo-bsc/osmo_bsc_main.c
2 files changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/65/25765/1

diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c
index 598641e..54d6b04 100644
--- a/src/osmo-bsc/bts.c
+++ b/src/osmo-bsc/bts.c
@@ -273,6 +273,7 @@
 	bts->si_common.chan_desc.t3212 = osmo_tdef_get(net->T_defs, 3212, OSMO_TDEF_CUSTOM, -1);
 	bts->si_common.cell_options.pwrc = 0; /* PWRC not set */
 	bts->si_common.cell_sel_par.acs = 0;
+	bts->si_common.ncc_permitted = 0xff;
 	gsm_bts_set_radio_link_timeout(bts, 32); /* Use RADIO LINK TIMEOUT of 32 */
 
 	INIT_LLIST_HEAD(&bts->abis_queue);
diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c
index 28a56a7..3a1a673 100644
--- a/src/osmo-bsc/osmo_bsc_main.c
+++ b/src/osmo-bsc/osmo_bsc_main.c
@@ -510,8 +510,6 @@
 		bts->si_common.chan_desc.ccch_conf = (n << 1);
 	}
 
-	bts->si_common.ncc_permitted = 0xff;
-
 	/* ACC ramping is initialized from vty/config */
 
 	/* Initialize the BTS state */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25765
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9f02277d7b4b4bcb383e749435416a0b22efd5e8
Gerrit-Change-Number: 25765
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211013/39e8d090/attachment.htm>


More information about the gerrit-log mailing list