Change in libosmo-abis[master]: ipaccess: e1inp_ipa_bts_rsl_connect: Fix memleak recreating ipa_clien...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue Oct 12 11:09:49 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/25742 )

Change subject: ipaccess: e1inp_ipa_bts_rsl_connect: Fix memleak recreating ipa_client_conn
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

https://gerrit.osmocom.org/c/libosmo-abis/+/25742/1/src/input/ipaccess.c 
File src/input/ipaccess.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/25742/1/src/input/ipaccess.c@a1170 
PS1, Line 1170: 
> It would be unrelated if I wasn't changing half of the function around it ;)
Ack


https://gerrit.osmocom.org/c/libosmo-abis/+/25742/1/src/input/ipaccess.c@1008 
PS1, Line 1008: 	struct ipa_client_conn *ipa_cli[NUM_E1_TS]; /* 0=OML, 1+N=TRX_N */
> I'm following same convention used in e1inp_line, so I prefer keeping it this way.
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/25742
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I4ee1ae318b446490783c8b910fca10ba5f72dd5a
Gerrit-Change-Number: 25742
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 12 Oct 2021 11:09:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211012/33f17d58/attachment.htm>


More information about the gerrit-log mailing list