Change in osmo-pcu[master]: pdch: Validate poll reason matches in rcv_control_(egprs)_dl_ack_nack()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Oct 12 09:07:59 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25747 )

Change subject: pdch: Validate poll reason matches in rcv_control_(egprs)_dl_ack_nack()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/25747/1/src/pdch.cpp 
File src/pdch.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/25747/1/src/pdch.cpp@468 
PS1, Line 468: 		LOGPDCH(this, DRLCMAC, LOGL_NOTICE, "PACKET DOWNLINK ACK with "
> The log message is not accurate anymore since it's also printing it now if it is not ACK/NACK. […]
It is accurate enough (most of these log messages are really old and I agree should be updated, but not high prio and not really related to this patch). We are receiving a PKT DL ACK/NACK, regardless of what we expected to receive according to our scheduler. This can well happen for different reasons, for instance due to MS broken implementation or our wrong understanding of the specs at some point.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25747
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I8ab3f5e4f2f802944269453db13a80c9ede67714
Gerrit-Change-Number: 25747
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 12 Oct 2021 09:07:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211012/6d315bfc/attachment.htm>


More information about the gerrit-log mailing list