Change in osmo-pcu[master]: pdch: Only release ULC entry if rx ul block matches the expected one

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Oct 12 09:05:41 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25746 )

Change subject: pdch: Only release ULC entry if rx ul block matches the expected one
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/25746/1/src/pdch.cpp 
File src/pdch.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/25746/1/src/pdch.cpp@443 
PS1, Line 443: 		/* Handled in rcv_control_dl_ack_nack() upon receival of DL ACK/NACK as a response to our POLL. */
> (I thought it is missing here, but rcv_control_dl_ack_nack() already calls pdch_ulc_release_fn(ulc,  […]
Indeed. It would probably be unexpected to receive a CTRL ACK here actually,so we ignore it.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25746
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia69a7d92c4b5c98ec71a75605c8dc3a755e63a35
Gerrit-Change-Number: 25746
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 12 Oct 2021 09:05:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211012/00224e38/attachment.htm>


More information about the gerrit-log mailing list