This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25747 ) Change subject: pdch: Validate poll reason matches in rcv_control_(egprs)_dl_ack_nack() ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/25747/1/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/25747/1/src/pdch.cpp@467 PS1, Line 467: PDCH_ULC_POLL_DL_ACK (This is a bit confusing IMHO since it's called _ACK and not _ACK_NACK. But according to the comment for the enum value it expects ACK/NACK.) /* Expect DL ACK/NACK requested by RRBP */ https://gerrit.osmocom.org/c/osmo-pcu/+/25747/1/src/pdch.cpp@468 PS1, Line 468: LOGPDCH(this, DRLCMAC, LOGL_NOTICE, "PACKET DOWNLINK ACK with " The log message is not accurate anymore since it's also printing it now if it is not ACK/NACK. Maybe change the message, or do a separate check with its own log message? While at it, maybe change ACK to ACK/NACK in the log message? Same below with the other log msg. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25747 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8ab3f5e4f2f802944269453db13a80c9ede67714 Gerrit-Change-Number: 25747 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-CC: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Tue, 12 Oct 2021 07:42:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211012/4461ee16/attachment.htm>