This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/25742 ) Change subject: ipaccess: e1inp_ipa_bts_rsl_connect: Fix memleak recreating ipa_client_conn ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/libosmo-abis/+/25742/1/src/input/ipaccess.c File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/25742/1/src/input/ipaccess.c@a1170 PS1, Line 1170: unrelated ws removal https://gerrit.osmocom.org/c/libosmo-abis/+/25742/1/src/input/ipaccess.c@1008 PS1, Line 1008: struct ipa_client_conn *ipa_cli[NUM_E1_TS]; /* 0=OML, 1+N=TRX_N */ I would simply have a separate pointer for the OML, and an array for the RSL: struct ipa_client_conn *ipa_oml_cli; struct ipa_client_conn *ipa_rsl_cli[NUM_E1_TS]; Currently it looks like a complication for no reason. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/25742 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I4ee1ae318b446490783c8b910fca10ba5f72dd5a Gerrit-Change-Number: 25742 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Mon, 11 Oct 2021 15:45:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211011/c9715153/attachment.htm>