Change in osmo-ggsn[master]: gtp_echo_responder: report invalid chars present in node-feautres cmd...

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/25728 )

Change subject: gtp_echo_responder: report invalid chars present in node-feautres cmdline arg as error
......................................................................

gtp_echo_responder: report invalid chars present in node-feautres cmdline arg as error

from "man strtoul":
"""
If endptr is not NULL, strtoul() stores the address of the first invalid character in *endptr.
In particular, if *nptr is not '\0' but **endptr is '\0' on return, the entire string is valid.
"""

Fixes: ae81195418ebed5280d0753d037df483bb914a0b
Change-Id: I89d26a575ef81ee17483db035924354588d9d094
---
M utils/gtp_echo_responder.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/utils/gtp_echo_responder.c b/utils/gtp_echo_responder.c
index e077c81..390fa25 100644
--- a/utils/gtp_echo_responder.c
+++ b/utils/gtp_echo_responder.c
@@ -125,7 +125,7 @@
 
 	res = strtoul(arg, &end, 0);
 	if ((errno == ERANGE && res == ULONG_MAX) || (errno && !res) ||
-	    arg == end) {
+	    arg == end || *end != '\0') {
 		fprintf(stderr, "Failed parsing Node Features bitmask: '%s'\n", arg);
 		exit(1);
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/25728
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I89d26a575ef81ee17483db035924354588d9d094
Gerrit-Change-Number: 25728
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211011/e2758cc3/attachment.htm>