Change in osmo-ci[master]: lint: support project-specific exclude paths

[osmith]

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25724 )

Change subject: lint: support project-specific exclude paths
......................................................................

lint: support project-specific exclude paths

While at it, put in the exact path to spelling.txt in osmo-ci.git.

Related: OS#5087
Change-Id: Ib23f9c65da1916ebf4654c5e641eaffe6c75315c
---
M lint/checkpatch/checkpatch_osmo.sh
1 file changed, 23 insertions(+), 11 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved



diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh
index 4710b7b..fd0e10a 100755
--- a/lint/checkpatch/checkpatch_osmo.sh
+++ b/lint/checkpatch/checkpatch_osmo.sh
@@ -1,12 +1,27 @@
 #!/bin/sh -e
 SCRIPT_DIR="$(dirname "$(realpath "$0")")"
+PROJECT="$(basename "$(git rev-parse --show-toplevel)")"
 
-# Excluded paths:
-# * \.(ok|err)$: stdout and stderr of regression tests
-# * ^debian/changelog$: generated from commit log, which may contain spelling errors (OS#5232)
-# * ^lint/checkpatch/: so it does not warn about spelling errors in spelling.txt :)
-# * ^src/gsm/kdf/: libosmocore: imported code
-# * ^src/gsm/milenage/: libosmocore: imported code
+exclude_paths_common() {
+	# Stdout and stderr of regression tests
+	echo '--exclude \.(ok|err)$'
+	# Generated from commit log, which may contain spelling errors (OS#5232)
+	echo '--exclude ^debian/changelog$'
+}
+
+exclude_paths_project() {
+	case "$PROJECT" in
+	libosmocore)
+		# Imported code
+		echo '--exclude ^src/gsm/kdf/'
+		echo '--exclude ^src/gsm/milenage/'
+		;;
+	osmo-ci)
+		# Do not warn about spelling errors in spelling.txt :)
+		echo '--exclude ^lint/checkpatch/spelling.txt$'
+		;;
+	esac
+}
 
 # Ignored checks:
 # * ASSIGN_IN_IF: not followed (e.g. 'if ((u8 = gsup_msg->cause))')
@@ -36,11 +51,8 @@
 # * UNSPECIFIED_INT: not followed (doesn't seem useful for us)
 
 $SCRIPT_DIR/checkpatch.pl \
-	--exclude '\.(ok|err)$' \
-	--exclude '^debian/changelog$' \
-	--exclude '^lint/checkpatch/' \
-	--exclude '^src/gsm/kdf/' \
-	--exclude '^src/gsm/milenage/' \
+	$(exclude_paths_common) \
+	$(exclude_paths_project) \
 	--ignore ASSIGN_IN_IF \
 	--ignore AVOID_EXTERNS \
 	--ignore BLOCK_COMMENT_STYLE \

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/25724
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ib23f9c65da1916ebf4654c5e641eaffe6c75315c
Gerrit-Change-Number: 25724
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211011/2b79670b/attachment.htm>