Change in osmo-bts[master]: gsm_lchan_name_update(): use shadow timeslot as talloc context

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Oct 8 17:25:32 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/25733 )


Change subject: gsm_lchan_name_update(): use shadow timeslot as talloc context
......................................................................

gsm_lchan_name_update(): use shadow timeslot as talloc context

This way if a shadow timeslot gets free()d, the associated name
also gets freed.  This does not apply to the primary timeslots,
because they're not talloc chunks but part of 'struct gsm_bts_trx'.

Change-Id: Ie449f931db5431e8aa4ab9b232b19d22cbd330aa
Related: OS#5248
---
M src/common/lchan.c
1 file changed, 7 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/33/25733/1

diff --git a/src/common/lchan.c b/src/common/lchan.c
index f7ee33b..8115df7 100644
--- a/src/common/lchan.c
+++ b/src/common/lchan.c
@@ -67,9 +67,15 @@
 {
 	const struct gsm_bts_trx_ts *ts = lchan->ts;
 	const struct gsm_bts_trx *trx = ts->trx;
+	void *talloc_ctx;
 	char *name;
 
-	name = talloc_asprintf(trx, "(" GSM_TS_NAME_FMT ",ss=%u)",
+	if (ts->vamos.is_shadow)
+		talloc_ctx = (void *)ts;
+	else
+		talloc_ctx = (void *)trx;
+
+	name = talloc_asprintf(talloc_ctx, "(" GSM_TS_NAME_FMT ",ss=%u)",
 			       GSM_TS_NAME_ARGS(ts), lchan->nr);
 	if (lchan->name != NULL)
 		talloc_free(lchan->name);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25733
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie449f931db5431e8aa4ab9b232b19d22cbd330aa
Gerrit-Change-Number: 25733
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211008/2b963dc0/attachment.htm>


More information about the gerrit-log mailing list