Change in pysim[master]: pySim-shell: allow card insertion at runtime

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Oct 8 09:20:49 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25549 )

Change subject: pySim-shell: allow card insertion at runtime
......................................................................


Patch Set 5:

(3 comments)

https://gerrit.osmocom.org/c/pysim/+/25549/3/pySim-shell.py 
File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/25549/3/pySim-shell.py@a109 
PS3, Line 109: 		self.ad
> why is this setting removed here? What ist he logic behind it?
It is not entirely removed. Its only added later with the equip() function. The reason for this is that conserve_write flag is in the runtime state, which might not exist (None) in this code path yet.


https://gerrit.osmocom.org/c/pysim/+/25549/3/pySim-shell.py@127 
PS3, Line 127: 		if (cmd_set != []):
> A more elegant solution would be: […]
Done


https://gerrit.osmocom.org/c/pysim/+/25549/3/pySim-shell.py@130 
PS3, Line 130: 		if (cmd_set != []):
> Same here. See https://stackoverflow.com/questions/53513/how-do-i-check-if-a-list-is-empty.
Done



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/25549
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9cf532d9da8203065463c7201e7064de6c7ab1b5
Gerrit-Change-Number: 25549
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 08 Oct 2021 09:20:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211008/008661f5/attachment.htm>


More information about the gerrit-log mailing list