Change in libosmocore[master]: ns2: fsm: add comment don't answer on a STATUS with a STATUS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Oct 8 05:43:48 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25556 )

Change subject: ns2: fsm: add comment don't answer on a STATUS with a STATUS
......................................................................

ns2: fsm: add comment don't answer on a STATUS with a STATUS

Change-Id: Ib8f700f9193a96a7bada3b0293dcecf6a05d6efc
---
M src/gb/gprs_ns2_vc_fsm.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gb/gprs_ns2_vc_fsm.c b/src/gb/gprs_ns2_vc_fsm.c
index a366c93..d09c31a 100644
--- a/src/gb/gprs_ns2_vc_fsm.c
+++ b/src/gb/gprs_ns2_vc_fsm.c
@@ -861,6 +861,7 @@
 	/* TODO: handle BLOCK/UNBLOCK/ALIVE with different VCI */
 
 	if (ns2_validate(nsvc, nsh->pdu_type, msg, tp, &cause)) {
+		/* don't answer on a STATUS with a STATUS */
 		if (nsh->pdu_type != NS_PDUT_STATUS) {
 			rc = ns2_tx_status(nsvc, cause, 0, msg);
 			goto out;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25556
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib8f700f9193a96a7bada3b0293dcecf6a05d6efc
Gerrit-Change-Number: 25556
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211008/63c8854c/attachment.htm>


More information about the gerrit-log mailing list