Change in osmo-bts[master]: Power-Loop: Fix LOG when Keeping MS Power level at the same level.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

keith gerrit-no-reply at lists.osmocom.org
Thu Oct 7 16:15:38 UTC 2021


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25694 )

Change subject: Power-Loop: Fix LOG when Keeping MS Power level at the same level.
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> > OK, I don't see how it makes sense to print the power level we "request", when we are not actually "requesting" anything.
> 
> For sure we are. 

I don't get you. When we hit the code path that logs the message in question then we return and we DO NOT exec any of:

/* store the resulting new MS power level in the lchan */
state->current = new_power_lvl;
bts_model_adjst_ms_pwr(lchan);

So nothing changes. the values


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25694
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I002b708cfda60371f57e32617e7ee33cb41c42f7
Gerrit-Change-Number: 25694
Gerrit-PatchSet: 2
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 07 Oct 2021 16:15:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211007/fc01162c/attachment.htm>


More information about the gerrit-log mailing list