This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/25652 )
Change subject: Introduce program gtp-echo-responder
......................................................................
Patch Set 7: Code-Review+1
(3 comments)
https://gerrit.osmocom.org/c/osmo-ggsn/+/25652/6/utils/gtp_echo_responder.c
File utils/gtp_echo_responder.c:
https://gerrit.osmocom.org/c/osmo-ggsn/+/25652/6/utils/gtp_echo_responder.c@106
PS6, Line 106: " Some useful help...\n"
How about: "arguments:\n"
https://gerrit.osmocom.org/c/osmo-ggsn/+/25652/6/utils/gtp_echo_responder.c@109
PS6, Line 109: " -l --listen-addr Listend address for GTPCv1 and GTPCv2\n"
> "Listen" (typo). ... or maybe "Address to listen on for ... […]
(still unresolved)
https://gerrit.osmocom.org/c/osmo-ggsn/+/25652/6/utils/gtp_echo_responder.c@128
PS6, Line 128: arg == end) {
> if arg should not contain trailing characters after the bitmask, you should also add '|| *end', i.e. […]
(still unresolved)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/25652
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Ibdd6d8f6920571db0c60cf8b3b25d541b15ad3f1
Gerrit-Change-Number: 25652
Gerrit-PatchSet: 7
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 07 Oct 2021 12:45:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211007/82f7511a/attachment.htm>