Change in libosmo-sccp[master]: osmo_sccp_simple_client_on_ss7_id(): Allow set internally proper IPv4...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Oct 7 11:36:58 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/25689 )

Change subject: osmo_sccp_simple_client_on_ss7_id(): Allow set internally proper IPv4/v6 default hosts
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmo-sccp/+/25689/1/src/osmo_ss7.c 
File src/osmo_ss7.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/25689/1/src/osmo_ss7.c@1279 
PS1, Line 1279: !(rem_has_v4 && !rem_has_v6)
> Can it be that no remote addr is set and no local addr is set? if that is the case, it seems that it […]
With current code: if ipv6 is supported, the only case where we don't want to use ipv6 in local addr (which being "::" means it will also support ipv4) is in the case where only remote ipv4 addresses are set.

If not remote addr and no local addr are set, then we'll pick the defaults, that is:
local="::" (which includes support listening for ipv4)
remote=("127.0.0.1","::1")



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/25689
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I82e203612571b7651d758d8148661f706a1642ba
Gerrit-Change-Number: 25689
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 07 Oct 2021 11:36:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211007/d569f775/attachment.htm>


More information about the gerrit-log mailing list